-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on truffleruby-head in CI #495
base: master
Are you sure you want to change the base?
Conversation
@@ -102,6 +105,9 @@ jobs: | |||
with: | |||
ruby-version: ${{ matrix.ruby }} | |||
|
|||
- run: sudo apt-get -yqq install libxml2-dev libxslt-dev | |||
if: startsWith(matrix.ruby, 'truffleruby') | |||
|
|||
- uses: actions/cache@v2 | |||
with: | |||
path: gemfiles/vendor/bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the fairly verbose logic here to cache bundle install
, did you try setup-ruby's bundler-cache: true
?
Was there any issue with it?
https://github.com/ruby/setup-ruby#caching-bundle-install-automatically has some docs about that and where to set BUNDLE_GEMFILE.
Pull Request Test Coverage Report for Build 408595900
💛 - Coveralls |
Thanks @eregon. I hadn't seen that note in the setup-ruby action. Hopefully I can find some time to experiment with it. I left truffleruby commented out because I was wondering about the usefulness of Better Errors in that runtime. Without binding_of_caller, there's not much functionality. We also don't run our tests on JRuby or Rubinius for the same reason. Do you see a real usefulness to Better Errors on truffleruby? Finally, since there's no released version of truffleruby we can run against, it seems like a real possibility that our tests will fail against the "head" on a arbitrary days. Since there's no "allow failure" setting in Github Actions, this would result in a failed build for reasons unrelated to the changed made to the local project. (This is why I left ruby-head out of the matrix.) So I would prefer to wait until there's a stable release that we can build on so that we can be sure of the reliability in CI. |
We'll probably add support for
It is useful to detect any potential incompatibility in TruffleRuby. |
TruffleRuby now targets Ruby 2.7, so Rails 4 is excluded just like on CRuby 2.7.